php 8.6 compatibility with all bundled extensions - #1226
Merged
Conversation
crazywhalecc
added
the
need-test
|
StaticPHP Test Bot Detected: Extensions: |
crazywhalecc
requested changes
Aug 10, 2026
Comment on lines
+33
to
+40
| /** These override pkg-config, so they must carry libpq itself too */ | ||
| public static function libpqConfigureVars(PackageBuilder $builder, PackageInstaller $installer): string | ||
| { | ||
| $closure = DependencyResolver::getResolvedPackageClosure(['postgresql'], array_keys($installer->getResolvedPackages())); | ||
| $libfiles = new SPCConfigUtil(['no_php' => true, 'libs_only_deps' => true])->configWithResolvedPackages($closure)['libs']; | ||
| return ' PGSQL_CFLAGS=-I' . $builder->getIncludeDir() . | ||
| ' PGSQL_LIBS="-L' . $builder->getLibDir() . ' ' . $libfiles . '"'; | ||
| } |
Owner
There was a problem hiding this comment.
This is definitely not the optimal solution. We could use configForResolvedBuild() instead of a static helper to achieve the same result.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Swoole couldn't possibly work, I'm not sure why it's even tested. |
Collaborator
Author
|
all the failing tests are now not-build-in extensions @crazywhalecc |
crazywhalecc
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
prepares php 8.6 compatibility
there's still a small issue with RHEL 9 and older, but that's for another pr
used craft.yml to test this: